Skip to content

Add mailmap and relicense internal/zeroable.rs & .clippy.toml#137

Merged
nbdd0121 merged 4 commits into
mainfrom
dev/relicense
Apr 28, 2026
Merged

Add mailmap and relicense internal/zeroable.rs & .clippy.toml#137
nbdd0121 merged 4 commits into
mainfrom
dev/relicense

Conversation

@BennoLossin
Copy link
Copy Markdown
Member

Cc @ojeda and @bonzini for the license change in .clippy.toml

@BennoLossin BennoLossin requested a review from nbdd0121 April 27, 2026 07:37
@bonzini
Copy link
Copy Markdown
Contributor

bonzini commented Apr 27, 2026

Acked-by: Paolo Bonzini: <pbonzini@redhat.com>

@nbdd0121
Copy link
Copy Markdown
Member

nbdd0121 commented Apr 27, 2026

Commits should be referenced with commit <hash> ("name")

The 3rd commit could also be reworded slightly:

The pin-init crate has been licensed under `Apache-2.0 OR MIT` since the
beginning. I introduced in commit 6478ecef7ab6 ("add `Zeroable` derive macro")
`zeroable.rs` with incompatible GPL-2.0 SPDX identifier. The file has not been
modified by other authors, so relicense it under the above license.

(I think there don't need to be a GitHub link, a claim is sufficient, those who want to verify can use git log --follow)

@ojeda
Copy link
Copy Markdown
Member

ojeda commented Apr 27, 2026

Acked-by: Miguel Ojeda <ojeda@kernel.org>

Signed-off-by: Benno Lossin <lossin@kernel.org>
Signed-off-by: Benno Lossin <lossin@kernel.org>
[ Added GitHub's noreply email as well - Gary ]
Signed-off-by: Gary Guo <gary@garyguo.net>
The pin-init crate has been licensed under `Apache-2.0 OR MIT` since the
beginning. I introduced in commit 6478ece ("add `Zeroable` derive
macro") `zeroable.rs` with incompatible GPL-2.0 SPDX identifier. The file
has not been modified by other authors, so relicense it under the above
license.

Signed-off-by: Benno Lossin <lossin@kernel.org>
[ Reworded commit message - Gary ]
Signed-off-by: Gary Guo <gary@garyguo.net>
The pin-init crate has been licensed under `Apache-2.0 OR MIT` since the
beginning. This file was introduced through a cherry pick commit
cc3d5ce ("rust: enable Clippy's `check-private-items`") of a
kernel commit 624063b9ac97 ("rust: enable Clippy's `check-private-items`")
with the GPL-2.0 SPDX identifier. We did not catch this in review, so
relicense the file now. Miguel is the original author
and has agreed to the relicense.

Link: #25
Acked-by: Paolo Bonzini <pbonzini@redhat.com>
Acked-by: Miguel Ojeda <ojeda@kernel.org>
Signed-off-by: Benno Lossin <lossin@kernel.org>
[ Reworded commit message - Gary ]
Signed-off-by: Gary Guo <gary@garyguo.net>
@nbdd0121 nbdd0121 merged commit 73163b6 into main Apr 28, 2026
22 checks passed
@nbdd0121 nbdd0121 deleted the dev/relicense branch April 28, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants