Skip to content

Conversation

@dvdsk
Copy link
Member

@dvdsk dvdsk commented Mar 15, 2025

reviews might be a good way to discuss this. We can merge it once we largely agree.

For big changes/additions a PR is probably best.

dvdsk and others added 2 commits March 16, 2025 10:35
Co-authored-by: Alice Cecile <alice.i.cecile@gmail.com>
goals.md Outdated
- combining the best ideas and code from existing projects.

# What
- a crate being a good base: We can implement all the needed use cases with
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What are the core use cases? Who wants to use audio crates in Rust? Are there key tradeoffs in the space?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes we should have those here. I have some answers to those questions but they are bound to be incorrect. I propose we

  • collect all possible use cases. If possible with some user story/context around those. To that end I have added what I know from Rodio.
  • document the tradeoffs
  • select which to focus on (the core use case).

Copy link
Contributor

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally could use a rewrite for grammar / writing quality: ping me when the content is done and I'll be happy to draft something up for you quick.

Very much a draft, I have added everything we currently have & want from
the rodio side. Since I know little of what Kira and Firewheel provide
or what Bevy needs (ECS what is that dark magic?!) I left that TODO.
@BillyDM
Copy link
Collaborator

BillyDM commented Mar 17, 2025

I think it would be helpful to explain how the Firewheel engine can be used to meet all of these goals. If you don't mind, I would like to write up my own draft text for project goals coming from own perspective. Then we can look into merging our drafts together.

@dvdsk
Copy link
Member Author

dvdsk commented Mar 18, 2025

I think it would be helpful to explain how the Firewheel engine can be used to meet all of these goals. If you don't mind, I would like to write up my own draft text for project goals coming from own perspective. Then we can look into merging our drafts together.

Good idea, I've added you to the repo feel free to push directly to main or open a PR. Let me know if you need anything.

@BillyDM
Copy link
Collaborator

BillyDM commented Mar 23, 2025

Alright, I added my own text to the document!

dvdsk added 3 commits March 25, 2025 12:44
While great additions goals was getting quite long. Future changes will
reference these sections again. Secondly this change makes it easier to
extend those sections in the future.
@dvdsk
Copy link
Member Author

dvdsk commented Mar 25, 2025

I am still working on incorporating the changes. Looking back project goals as a title was not a good starting point :)
I'll let everyone know when its ready for another review 👍

@dvdsk
Copy link
Member Author

dvdsk commented Mar 25, 2025

I've moved things around. There is now one short Readme with multiple supporting pieces.

  • I felt like the project goals should be the first you see so it has largely replaced the Readme text.
  • I have also introduced a distinction between requirements and the proposed tech stack. This makes more sense to me as the requirements should lead to the right stack for audio in rust.

We have a good base now, provided there are no major objections I would like to merge this as is. Further changes would then be new new PR's.

Copy link
Contributor

@alice-i-cecile alice-i-cecile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No major objections. Bother me for an editing pass before widespread publication but I agree on merging.

@dvdsk dvdsk merged commit 26cd040 into main Mar 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants