Merged
Conversation
micahrj
requested changes
Mar 28, 2024
micahrj
requested changes
Mar 29, 2024
micahrj
approved these changes
Mar 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a variety of checks to the CI:
-D warnings. This is done for all platforms, with or without the OpenGL feature.cargo docwith-D warnings.clippywith-D warnings(but otherwise only the default lints).rustfmt.This PR also applies some light formatting and code fixes that were detected by
rustfmtandclippy.This also makes some updates to the actions used:
actions/checkouttov4actions-rs/toolchain(which is not maintained anymore) todtolnay/rust-toolchaininsteadSome further work that is not covered by this PR:
missing-safety-doclint has been temporarily disabled. This will be re-enabled in another PR that will add the proper safety docs to the affected functions.cargo-denyhas been discussed, but I prefer adding it in a later PR as it can be its own can of worms regarding licenses and dependencies.