macOS: Use CFUUID instead of the uuid crate for a random class name#243
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of the
uuidcrate with the Core FoundationCFUUIDAPI, when creating a random class name for ourNSViewclass.This allows us to drop the
uuiddependency (at least on macOS), while keeping the same functionality.Note that the
CFUUIDAPIs currently generate a UUIDv4, which is equivalent to our current implementation.However, even if that were to change, any UUID version (time-based, random-based, or any mix of both) works for our use-case of avoiding runtime namespace collisions between plugins and the host.
This use-case actually being what the
CFUUIDAPI is built for, this will still work long-term.