Skip to content

Windows: Fix DND on non-parented windows (bugfix)#249

Merged
prokopyl merged 2 commits into
RustAudio:masterfrom
AlexCharlton:win-fix-dnd
May 25, 2026
Merged

Windows: Fix DND on non-parented windows (bugfix)#249
prokopyl merged 2 commits into
RustAudio:masterfrom
AlexCharlton:win-fix-dnd

Conversation

@AlexCharlton
Copy link
Copy Markdown
Contributor

Hi Rustaudio, I'm opening up a slew of PRs so I figured I'd provide a small preamble for this first one. I had forked baseview years ago and quickly diverged enough that I never wound up trying to submit anything upstream. With the 0.1 release I finally decided get on board and contribute back.

The majority of these are relatively small bugfixes for Windows, though a few are new features – The PR descriptions will indicate what the contents contain.

Thanks in advance for the reviews!


Filtering GetMessageW to hwnd precludes getting events from the OLE thread that's handling the DND. In practice this means that when dragging something into the baseview window, the drag process (that OLE thread) freezes up, making it impossible to complete the drag.

@prokopyl
Copy link
Copy Markdown
Member

Hi! And thanks for submitting your changes, it is much appreciated!

Your PRs have quite a variety of changes between bug fixes, new features, platform support, some breaking changes and other improvements, so I'm going to order them according to our short-term roadmap, and then review them in that priority order.

That means I'm likely gonna make a few minor releases before I'll get to your bigger PRs. 🙂

@prokopyl prokopyl self-assigned this May 25, 2026
@prokopyl prokopyl added this to the v0.1.2 - Safer internals milestone May 25, 2026
Comment thread src/win/window.rs
@AlexCharlton
Copy link
Copy Markdown
Contributor Author

Your PRs have quite a variety of changes between bug fixes, new features, platform support, some breaking changes and other improvements, so I'm going to order them according to our short-term roadmap, and then review them in that priority order.

Thanks for reviewing, @prokopyl! This makes sense to me!

Filtering GetMessageW to hwnd precludes getting events from the OLE thread that's handling the DND.
Copy link
Copy Markdown
Member

@prokopyl prokopyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks good to me now! Thank you!

@prokopyl prokopyl merged commit dca1a51 into RustAudio:master May 25, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants