Windows: Ensure WindowEvent::Resized is sent when opening a SystemScaleFactor window (bugfix)#254
Merged
prokopyl merged 1 commit intoMay 25, 2026
Conversation
prokopyl
force-pushed
the
win-resized-on-system-scale-factor
branch
from
e3bc805 to
165e2c5
Compare
prokopyl
approved these changes
May 25, 2026
prokopyl
force-pushed
the
win-resized-on-system-scale-factor
branch
from
165e2c5 to
790017b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows forces you to open a window before you can get the screen's scale factor. This means that when we call the
buildcallback, we don't actually know the scale factor. Only after callingbuilddo we resize the window to the correct size. baseview users need to know how big their windows are though, but because they can't get the right size atbuild, they rely on getting aWindowEvent::Resizedevent after the window has opened.This of course means that a
WindowEvent::Resizedneeds to actually be sent. We were relying on a call toSetWindowPos(the one doing the window resizing after we get the scale factor) to passively trigger the event, but this wasn't actually getting delivered to the handler. This PR explicitly sendsResizedto theWindowHandler::on_eventinstead.