Skip to content

Comments

Fix aaudio device name in device.description().name()#1103

Draft
SuperKenVery wants to merge 1 commit intoRustAudio:masterfrom
SuperKenVery:fix/superkenvery/desc-name
Draft

Fix aaudio device name in device.description().name()#1103
SuperKenVery wants to merge 1 commit intoRustAudio:masterfrom
SuperKenVery:fix/superkenvery/desc-name

Conversation

@SuperKenVery
Copy link
Contributor

#965 fixed this for device.name(), which is now a deprecated method. I let .description().name() return the same name.

@SuperKenVery SuperKenVery force-pushed the fix/superkenvery/desc-name branch from d0d6635 to 400cfdd Compare February 15, 2026 10:27
@roderickvd
Copy link
Member

I'm not super-clear on the intent, can you elaborate? It seems that currently returning info.product_name is the same that #965 did?

@SuperKenVery
Copy link
Contributor Author

In #965, the name is changed to product name and device type, on android. Product name is always the device model.

You may see the code diff, it's a one line change, and the implementation of name is a few lines above.

@roderickvd
Copy link
Member

If I understand correctly, you are saying that you prefer the behavior of #965? Because I found it weird that a "name" includes a device type and an address.

@SuperKenVery
Copy link
Contributor Author

Yes on android. The product name on android is same for every device; it's always the phone product name.

Screenshot_2026-02-19-12-14-31-66_b77199ee68e84a36b2a4aee65dc48fbd

Without this pr, all of them will be PJX110

@setoelkahfi
Copy link

I didn't see this before working on fixing #969 I have my own patch locally. What's the status here?

@SuperKenVery
Copy link
Contributor Author

@setoelkahfi seems we are doing the same thing, with a little bit different implementation details 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants