refactor(audio_thread_priority): use actual buffer size and report specific error kind#1179
Merged
roderickvd merged 2 commits intomasterfrom Apr 26, 2026
Merged
Conversation
roderickvd
force-pushed
the
refactor/audio-thread-priority
branch
from
06ee0fd to
e7ab0b5
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Opportunistic refactoring to remove the custom ControlFlow enum and switch functions to use std::ops::ControlFlow.
roderickvd
force-pushed
the
refactor/audio-thread-priority
branch
from
e7ab0b5 to
07693ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
ErrorKind:: ThreadPriorityUnavailableto indicate a transient error: the stream may still play but not at the requested priority escalation.Also ensure that WASAPI and ALSA use the actual period size - not what was requested with
BufferSize::Fixed()(it may have negotiated a different value) and not the full buffer size.