fix(coreaudio): aggregate-device uuid collision + auto start to true#1198
Merged
Conversation
umerhd
changed the title
roderickvd
reviewed
May 11, 2026
Member
roderickvd
left a comment
roderickvd
left a comment
There was a problem hiding this comment.
Thanks for catching and fixing this! Two minor points if you'd take a look at them. And if you would also add a short entry to CHANGELOG.md?
umerhd
force-pushed
the
fix/coreaudio-loopback
branch
from
7f1e74d to
fe25cad
Compare
roderickvd
reviewed
May 11, 2026
| /// @kAudioAggregateDeviceTapListKey : taps, | ||
| /// @kAudioAggregateDeviceTapAutoStartKey : @NO, | ||
| /// @kAudioAggregateDeviceTapAutoStartKey : @YES, | ||
| /// // If we set this to NO then I believe we need to make the Tap public as |
Member
There was a problem hiding this comment.
This comment can then be deleted, right?
umerhd
force-pushed
the
fix/coreaudio-loopback
branch
from
fe25cad to
b665a5a
Compare
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two independent bugs in macOS LoopbackDevice, one commit each.