refactor(wasapi): centralize stream error handling#1209
Merged
Conversation
7606c7b to
44835c5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the WASAPI backend's stream loops so process_input/process_output return Result<(), Error> instead of ControlFlow<()>, centralizing error emission in the callers (run_input/run_output). Behavior is preserved: on error the error callback is invoked and the loop breaks; on the prior "continue" paths (Ok(0) packet size, buffer-empty), the functions simply return Ok(()) and the outer loop iterates.
Changes:
process_input/process_outputno longer take anerror_callbackparameter and now propagate errors via?.run_input/run_outputhandle the returnedResultby emitting througherror_callbackand breaking.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
process_input/process_outputreturnResultand remove theirerror_callbackparameter.