This repository was archived by the owner on Mar 27, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Bitwig wasn't getting the VST's name anymore:
I assume this is because Bitwig used to issue a
GetProductNameopcode to get this, but now it's issuing theGetEffectNameopcode instead.Fix
I simply copy-pasted what we had for
GetProductNameand made it theGetEffectNamehandler too:I know that Carla/JUCE uses this same opcode to fill in the plugin name (they call their equivalent opcode
plugInOpcodeGetPlugInNamehere).Question
I couldn't find out what
GetProductNameis supposed to be used for, from a quick glance at the Carla code. What should we do there instead?