Switch to NSMetadataQuery for search, add file icons#227
Merged
unsecretised merged 3 commits intoRustCastLabs:masterfrom Mar 25, 2026
Merged
Switch to NSMetadataQuery for search, add file icons#227unsecretised merged 3 commits intoRustCastLabs:masterfrom
unsecretised merged 3 commits intoRustCastLabs:masterfrom
Conversation
unsecretised
requested changes
Mar 25, 2026
Collaborator
unsecretised
left a comment
unsecretised
left a comment
There was a problem hiding this comment.
the module has been made public so u can use that instead of doing the wrapper fn
Contributor
|
thanks for taking this over! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches the file search implementation from calling
mfindto natively usingNSMetadata. This leverages the built in Spotlight search index, but without a call to an external application.In addition, this PR updates the file search UI to include async loading of file icons:
