README: replace build badges column with MSRV#337
Merged
Conversation
Member
|
Alternatively we could get all of the MSRVs in sync, e.g. 1.51+. That would make it possible to re-unify the |
Member
Author
|
I don't think we should bump MSRV without a good reason. For example, at my current job we want to be able to build some crates with older toolchains (at the very least 1.41, since it's the version packaged in Debian). And even assuming we had synchronized MSRVs, I feel that the build badges are somewhat pointless. I don't think they have been useful to us even once, despite them taking a significant space in our READMEs. Also we don't even have cron jobs in our workflows, so the only place where things can break is in PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think MSRV information is more valuable than the build badges, especially considering that in this repository we have crates with 3 different MSRVs.
Also I've removed the
aes-ccmmention, since theccmcrate should be preferred for now. Later we probably should introduce a folder with crates containing common common composition of primitives (AES-GCM, ChaCha20Poly1305, etc.).