ascon-aead: update for NIST draft (fixes #668) #669
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newpavlov
reviewed
Mar 17, 2025
ascon-aead/CHANGELOG.md
Outdated
| - Edition changed to 2024 and MSRV bumped to 1.85 ([#662]) | ||
| - Relax MSRV policy and allow MSRV bumps in patch releases | ||
| - `getrandom` feature renamed as `os_rng` ([#662]) | ||
| - Update for compliance with NIST draft |
Member
There was a problem hiding this comment.
Add reference to this PR and to the NIST draft.
I also think it's better to move the removal entry to the removed section.
sebastinas
force-pushed
the
ascon-aead-nist-draft
branch
from
cf8900f to
f01ea94
Compare
tarcieri
approved these changes
Mar 17, 2025
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
Curious what happened with the KATs (i.e. why there were so many before and so few now), but otherwise this looks good
Member
IIUC it's because of the removed variants. |
Contributor
Author
Yes, the other KATs were for the removed variants. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.