ml-kem: validate encryption/encapsulation keys #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Here's the relevant section of FIPS 203: 
I think this should accomplish that goal |
Adds a check that decoded `EncryptionKey`s successfully round-trip encode back to the bytes they were decoded from, in order to detect malformed keys. Closes #172
tarcieri
force-pushed
the
ml-kem/encryption-key-validation
branch
from
4ef27cd to
15ab57a
Compare
|
This was the fix in my lib that made my fuzzer happy:
https://github.com/dark-bio/crypto-rs/blob/a1f87044714d08929ac5c6a77938804e30538a6b/src/xhpke/mod.rs#L306
I’ll pull your changes and rerun the fuzzer to see if it finds anything.
But am flying now so unsure exactly when.
Thx for looking into it
…On Sat, 10 Jan 2026 at 21:02, Tony Arcieri ***@***.***> wrote:
Merged #179 <#179> into master.
—
Reply to this email directly, view it on GitHub
<#179 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAA7UGKNFXHX624S3JHDEBL4GFEELAVCNFSM6AAAAACRH5Q52KVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMRRHE3DKNJVGIZTMNA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Member
Author
|
Yeah, per #172 I was looking into doing something like that, but then found FIPS 203 §7.2 which recommended this sort of round-trip serialization approach instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a check that decoded
EncryptionKeys successfully round-trip encode back to the bytes they were decoded from, in order to detect malformed keys.Closes #172
cc @karalabe