pkcs1v15: change VerifyingKey::from to use prefixed version
#472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed in RustCrypto#341, `pkcs1v15::VerifyingKey::from` should use the prefixed keys.
baloo
force-pushed
the
baloo/pkcs1v15/use-prefixed-verifying-keys
branch
from
407f89b to
eb1e34d
Compare
tarcieri
approved these changes
Feb 5, 2025
tarcieri
changed the title
VerifyingKey::from to use prefixed version
marshallpierce
added a commit
to marshallpierce/RSA
that referenced
this pull request
Mar 12, 2025
This matches RustCrypto#472.
marshallpierce
added a commit
to marshallpierce/RSA
that referenced
this pull request
Mar 12, 2025
This matches RustCrypto#472.
marshallpierce
added a commit
to marshallpierce/RSA
that referenced
this pull request
Mar 12, 2025
This matches RustCrypto#472.
marshallpierce
added a commit
to marshallpierce/RSA
that referenced
this pull request
Mar 12, 2025
This matches RustCrypto#472.
marshallpierce
added a commit
to marshallpierce/RSA
that referenced
this pull request
Mar 12, 2025
This matches RustCrypto#472.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #341,
pkcs1v15::VerifyingKey::fromshould use the prefixed keys.Just lost a couple hours on this one behavior, and since 0.10 is just around the corner, might as well fix it before that.
Fixes #341