Make SigningKey::from use Self::new() #498
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshallpierce
force-pushed
the
mp/signing-key-from
branch
from
0b906f3 to
5d786b2
Compare
tarcieri
reviewed
Mar 12, 2025
marshallpierce
force-pushed
the
mp/signing-key-from
branch
2 times, most recently
from
0038884 to
6db9d10
Compare
This matches RustCrypto#472.
marshallpierce
force-pushed
the
mp/signing-key-from
branch
from
6db9d10 to
2817868
Compare
tarcieri
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches #472.