fix: reject prime == 1 in validate_private_key_parts
#655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
approved these changes
Feb 9, 2026
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
Sidebar: this should probably use a constant-time comparison, but this is a start
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The guard in validate_private_key_parts used prime < 1 instead of prime <= 1, so it only caught zero but let prime == 1 slip through. A few lines below, NonZero::new(prime - 1).unwrap() panics on zero, exactly as the existing comment warns: "Any primes ≤ 1 will cause divide-by-zero panics later."