minimal-versions: replace workspace Cargo.toml instead of deleting #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generates a stub Cargo.toml at the workspace level which configures a workspace with one member whose path is the current working directory
tarcieri
commented
Jan 21, 2026
newpavlov
approved these changes
Jan 21, 2026
Member
newpavlov
left a comment
newpavlov
left a comment
There was a problem hiding this comment.
Ideally, it would be nice to modify only the members field and keep everything else in Cargo.toml. It would help with temporary patching since right now we have to disalbe minimal versions jobs when it present. But I guess we can improve it later.
Also note the failing lint.
newpavlov
reviewed
Jan 21, 2026
| @@ -0,0 +1,2 @@ | |||
| rules: | |||
| line-length: disable | |||
Member
There was a problem hiding this comment.
IIRC it's possible to split run commands into multiple lines.
Member
Author
There was a problem hiding this comment.
I would rather not have to debug syntax issues in YAML configuration files because some lint is telling me every line must be 80 characters long, which is a silly restriction to begin with
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generates a stub Cargo.toml at the workspace level which configures a workspace with one member whose path is the current working directory.
I think this might resolve the problem I was having with using workspace-level configs in conjunction with
minimal-versionson RustCrypto/utils#1411Not sure how to test it