minimal-versions: use heredoc to write Cargo.toml #53
+7
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make the replacement workspace-level Cargo.toml a little easier to edit, this attempts writing it with a heredoc and interpolating `$(pwd)` into it. The config now includes an empty `[workspace.lints]` section so the `lints.workspace = true` configuration in each crate's Cargo.toml actually still functions.
tarcieri
commented
Jan 21, 2026
| with: | ||
| toolchain: ${{ inputs.nightly }} | ||
| # Replace Cargo.toml at the workspace-level with a stub which still allows workspace-level configs to function | ||
| - run: printf "[workspace]\nmembers=[\"%q\"]" $(pwd) > ../Cargo.toml |
Member
Author
There was a problem hiding this comment.
So %q isn't right anyway, it's shell escaping whereas we need the input quoted.
But right now the real issue is just getting it to template a configuration that actually works.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make the replacement workspace-level Cargo.toml a little easier to edit, this attempts writing it with a heredoc and interpolating
$(pwd)into it.The config now includes an empty
[workspace.lints]section so thelints.workspace = trueconfiguration in each crate's Cargo.toml actually still functions.