der: have Reader::peek* methods take &mut self
#1418
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now `PemReader` uses interior mutability via `RefCell`, because peeking might involve filling an internal peek buffer (i.e. decoding the Base64 in a PEM document). Rather than trying to hide the fact we're potentially modifying internal buffers (but not the cursor/position) when peeking, this changes the methods to explicitly accept `&mut self`, and with that change eliminates all usages of `RefCell`. This change appears to have no practical drawbacks, since peeking always occurs during the decoding process where we need mutable access to the reader anyway.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now
PemReaderuses interior mutability viaRefCell, because peeking might involve filling an internal peek buffer (i.e. decoding the Base64 in a PEM document).Rather than trying to hide the fact we're potentially modifying internal buffers (but not the cursor/position) when peeking, this changes the methods to explicitly accept
&mut self, and with that change eliminates all usages ofRefCell.This change appears to have no practical drawbacks, since peeking always occurs during the decoding process where we need mutable access to the reader anyway.