Skip to content

der: rename decode_value fns for cleaner cargo bloat output#1802

Merged
tarcieri merged 1 commit into
RustCrypto:masterfrom
dishmaker:dishmaker/der_bloat_rename_fns
May 4, 2025
Merged

der: rename decode_value fns for cleaner cargo bloat output#1802
tarcieri merged 1 commit into
RustCrypto:masterfrom
dishmaker:dishmaker/der_bloat_rename_fns

Conversation

@dishmaker
Copy link
Copy Markdown
Contributor

Same command, cargo bloat,

before:

./formats$ cargo bloat -p x509-cert --test certificate --filter "decode_value" --full-fn -w --release -n 40
    Analyzing target/release/deps/certificate-4493036956d2881b

File .text   Size Crate Name
0.0%  0.0%   383B   der der::asn1::integer::uint::<impl der::decode::DecodeValue for u8>::decode_value::h99fa4cf07ef3366b
0.0%  0.0%   362B   der der::asn1::integer::uint::<impl der::decode::DecodeValue for u8>::decode_value::he68458e496aeea63
0.0%  0.0%   295B   der <der::asn1::bit_string::allocating::BitString as der::decode::DecodeValue>::decode_value::hc7370e53337cbdd6
0.0%  0.0%   263B   der <der::asn1::bit_string::allocating::BitString as der::decode::DecodeValue>::decode_value::h5311ed49f05453cb
0.0%  0.2% 1.3KiB       filtered data size, the file size is 6.0MiB

after:

./formats$ cargo bloat -p x509-cert --test certificate --filter "decode_value" --full-fn -w --release -n 40
    Analyzing target/release/deps/certificate-4493036956d2881b

File .text    Size     Crate Name
0.1%  0.5%  3.7KiB x509_cert x509_cert::certificate::TbsCertificateInner<P>::decode_value_inner::h07b3b3e36b1ea385
0.0%  0.4%  3.1KiB x509_cert x509_cert::certificate::TbsCertificateInner<P>::decode_value_inner::h042a3c59808e9aea
0.0%  0.2%  1.2KiB x509_cert x509_cert::certificate::CertificateInner<P>::decode_value_inner::hbafc9ba47162d38a
0.0%  0.1%    908B x509_cert x509_cert::certificate::CertificateInner<P>::decode_value_inner::h4dee5104b2da5035
0.0%  0.1%    826B x509_cert x509_cert::ext::Extension::decode_value_inner::h1d0406f3ccc041a7
0.0%  0.1%    591B       der der::asn1::sequence_of::decode_value_vec_inner::h119530d8874a7464
0.0%  0.1%    590B       der der::asn1::sequence_of::decode_value_vec_inner::hebb22b35ad16ce05
0.0%  0.1%    575B x509_cert x509_cert::ext::Extension::decode_value_inner::hb0094754755ecf46
0.0%  0.1%    572B x509_cert x509_cert::attr::AttributeTypeAndValue::decode_value_inner::h699eec2126eb5649
0.0%  0.1%    499B       der der::asn1::sequence_of::decode_value_vec_inner::h63c76e6025c2757b
0.0%  0.1%    499B       der der::asn1::sequence_of::decode_value_vec_inner::h15931c8a9a04d790
0.0%  0.0%    383B       der der::asn1::integer::uint::<impl der::decode::DecodeValue for u8>::decode_value::h99fa4cf07ef3366b
0.0%  0.0%    362B       der der::asn1::integer::uint::<impl der::decode::DecodeValue for u8>::decode_value::he68458e496aeea63
0.0%  0.0%    295B       der <der::asn1::bit_string::allocating::BitString as der::decode::DecodeValue>::decode_value::hc7370e53337cbdd6
0.0%  0.0%    263B       der <der::asn1::bit_string::allocating::BitString as der::decode::DecodeValue>::decode_value::h5311ed49f05453cb
0.2%  1.8% 14.2KiB           filtered data size, the file size is 6.0MiB

@tarcieri tarcieri merged commit 0fbce40 into RustCrypto:master May 4, 2025
107 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants