Conversation
Adds an enum to be carried along with `pkcs8::Error::KeyMalformed` that can give more specific details about what is wrong with the key, e.g. is it being rejected because it's too short or too long. This has been requested by people who say the existing variant doesn't give enough detail to diagnose the problem.
tarcieri
force-pushed
the
pkcs8/add-keyerror
branch
from
a19ab42 to
241075e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an enum to be carried along with
pkcs8::Error::KeyMalformedthat can give more specific details about what is wrong with the key, e.g. is it being rejected because it's too short or too long.This has been requested by people who say the existing variant doesn't give enough detail to diagnose the problem.