Add Debug bound to ArraySize
#165
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came up with `elliptic-curve` and `sec1` as I was working on
`dhkem`:
error[E0277]: `<C as elliptic_curve::Curve>::FieldBytesSize` doesn't
implement `Debug`
--> dhkem/src/ecdh_kem.rs:80:5
|
80 | / fn encapsulate_with_rng<R: TryCryptoRng + ?Sized>(
81 | | &self,
82 | | rng: &mut R,
83 | | ) -> Result<(PublicKey<C>, SharedSecret<C>),
Self::Error> {
|
|_____________________________________________________________^
the trait `Debug` is not implemented for `<C as
elliptic_curve::Curve>::FieldBytesSize`
`sec1::point::ModulusSize` bounds on `Debug`, but
`elliptic_curve::Curve::FieldBytesSize` does not. Yet for whatever
reason in `elliptic-curve` it's able to get away with:
FieldBytesSize<C>: ModulusSize
Instead of adding a `Debug` bound to `Curve::FieldBytesSize` I thought I
would add it here instead to solve this problem for good.
This shouldn't be breaking, because `ArraySize` bounds on
`typenum::Unsigned`, which means it's impossible for 3rd party crates to
impl as they would need to add impls to a foreign type which isn't
allowed by the orphan rules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up with
elliptic-curveandsec1as I was working ondhkem:sec1::point::ModulusSizebounds onDebug, butelliptic_curve::Curve::FieldBytesSizedoes not. Yet for whatever reason inelliptic-curveit's able to get away with:Instead of adding a
Debugbound toCurve::FieldBytesSizeI thought I would add it here instead to solve this problem for good.This shouldn't be breaking, because
ArraySizebounds ontypenum::Unsigned, which means it's impossible for 3rd party crates to impl as they would need to add impls to a foreign type which isn't allowed by the orphan rules.