ml-dsa: factor from_seed method onto SigningKey#1341
Merged
Conversation
Extracts a `SigningKey::from_seed` that was previously defined on `MlDsaParams` via a trait impl. This changes it to an inherent method, and has the trait method call the inherent method. This makes it possible to restrict the visibility of `SigningKey` fields, addressing a TODO.
tarcieri
force-pushed
the
ml-dsa/signing-key-from-seed
branch
from
27db609 to
ff2c05d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracts a
SigningKey::from_seedthat was previously defined onMlDsaParamsvia a trait impl.This changes it to an inherent method, and has the trait method call the inherent method.
This makes it possible to restrict the visibility of
SigningKeyfields, addressing a TODO.