ml-dsa: use MaybeBox to store VerifyingKey#1344
Merged
Merged
Conversation
When the `alloc` feature is enabled, uses `Box` to offload the largest parts of `VerifyingKey` to the heap. This also extracts an internal `PrecomputedValues` struct to store the largest components of the key, which are all derived/precomputed values, as a single contiguous struct in a `MaybeBox`, and extracts some of the relevant logic to it.
tarcieri
force-pushed
the
ml-dsa/use-maybebox-with-verifyingkey
branch
from
bdaa3f7 to
b74d60c
Compare
tarcieri
added a commit
that referenced
this pull request
May 9, 2026
Adds an `alloc`-gated `verifying_key` field to `SigningKey`, and when the feature is enabled precomputes the key at the time the `SigningKey` is initialized. We previously used to do this but stopped to optimize stack usage (see the changes in #1259 and #1261), however when `alloc` is enabled this isn't an issue since we've moved the relevant data to the heap in this case (see #1344 and #1345), so stack usage is no longer an issue. This makes it possible to implement `signature::KeypairRef` for `SigningKey` which still provides a blanket `signature::Keypair` impl, so we can always depend on the latter being availble but take advantage of the former when `alloc` is enabled.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the
allocfeature is enabled, usesBoxto offload the largest parts ofVerifyingKeyto the heap.This also extracts an internal
PrecomputedValuesstruct to store the largest components of the key, which are all derived/precomputed values, as a single contiguous struct in aMaybeBox, and extracts some of the relevant logic to it.