feat(ed25519): Add a feature to serialize with serde's bytes type#338
Closed
connec wants to merge 1 commit intoRustCrypto:masterfrom
connec:serde_as_bytes
Closed
feat(ed25519): Add a feature to serialize with serde's bytes type#338connec wants to merge 1 commit intoRustCrypto:masterfrom connec:serde_as_bytes
connec wants to merge 1 commit intoRustCrypto:masterfrom
connec:serde_as_bytes
Conversation
This introduces a new feature, `serde_as_bytes`, that switches the implementation of (de)serialization to use serde's `*_bytes` methods, allowing crate consumers to opt-in to this approach which is beneficial for formats with optimised byte array representations. This has required a small change to the test workflow, since it's necessary to test both with and without the `serde_as_bytes` feature. The features cannot be made mutually exclusive, though logically they are, without changing the `serde` feature flag, which would be backwards-incompatible. Fixes #336.
This was referenced Jul 21, 2021
Contributor
Author
|
Closing in favour of #337. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative fix for #336 introducing a feature to swap between
*_bytesand non-*_bytesserialization – the two are mutually exclusive!This introduces a new feature,
serde_as_bytes, that switches theimplementation of (de)serialization to use serde's
*_bytesmethods,allowing crate consumers to opt-in to this approach which is beneficial
for formats with optimised byte array representations.
This has required a small change to the test workflow, since it's
necessary to test both with and without the
serde_as_bytesfeature.The features cannot be made mutually exclusive, though logically they
are, without changing the
serdefeature flag, which would bebackwards-incompatible.
Fixes #336.