ed25519: add Signature::BYTE_SIZE + other cleanups#380
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #380 +/- ##
==========================================
+ Coverage 53.60% 53.82% +0.21%
==========================================
Files 8 9 +1
Lines 319 314 -5
==========================================
- Hits 171 169 -2
+ Misses 148 145 -3
Continue to review full report at Codecov.
|
- Adds inherent constant `Signature::BYTE_SIZE`; deprecates `SIGNATURE_LENGTH` constant. - Address TODOs - Factor tests into `tests/`
tarcieri
force-pushed
the
ed25519/byte-size-constant
branch
from
db1f8c3 to
e20b801
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signature::BYTE_SIZE; deprecatesSIGNATURE_LENGTHconstant.tests/