Skip to content

ed25519: remove deprecated infallible conversions #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tarcieri merged 1 commit into from
Nov 1, 2022
Merged

ed25519: remove deprecated infallible conversions #564

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions ed25519/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,19 +321,6 @@ impl Signature {
pub fn to_vec(&self) -> Vec<u8> {
self.0.to_vec()
}

/// DEPRECATED: Create a new signature from a byte array.
///
/// # Panics
///
/// This method will panic if an invalid signature is encountered.
///
/// Use [`Signature::from_bytes`] or [`Signature::try_from`] instead for
/// a fallible conversion.
#[deprecated(since = "1.3.0", note = "use ed25519::Signature::from_bytes instead")]
pub fn new(bytes: [u8; Self::BYTE_SIZE]) -> Self {
Self::from_bytes(&bytes[..]).expect("invalid signature")
}
}

impl SignatureEncoding for Signature {
Expand Down Expand Up @@ -362,19 +349,6 @@ impl From<&Signature> for [u8; Signature::BYTE_SIZE] {
}
}

/// DEPRECATED: use `TryFrom<&[u8]>` instead.
///
/// # Warning
///
/// This conversion will panic if a signature is invalid.
// TODO(tarcieri): remove this in the next breaking release
impl From<[u8; Signature::BYTE_SIZE]> for Signature {
fn from(bytes: [u8; Signature::BYTE_SIZE]) -> Signature {
#[allow(deprecated)]
Signature::new(bytes)
}
}

impl TryFrom<&[u8]> for Signature {
type Error = Error;

Expand Down