ed25519: change Signature::from_bytes to take sized array#593
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Dec 2, 2022
Merged
ed25519: change Signature::from_bytes to take sized array#593tarcieri merged 1 commit intoRustCrypto:masterfrom
tarcieri merged 1 commit intoRustCrypto:masterfrom
Conversation
Contributor
Author
|
context: dalek-cryptography/ed25519-dalek#230 (comment) |
tarcieri
reviewed
Dec 2, 2022
Change Signature::from_bytes to take `[u8; 64]` as argument rather than `&[u8]` which: - provides consistency with KeypairBytes::from_bytes, - encodes the length in type system allowing clients to assert length at compile time and - removes run-time length check. At the same time, since there’s already TryFrom<&[u8]> implementation for Signature, no features are lost and clients who want to create the signature from a slice can do it via Signature::try_from. This does change the API but since the crate is currently in 2.0 preview stage, that should be fine since API breaking changes are allowed by symantic versioning at major version upgrade.
tarcieri
approved these changes
Dec 2, 2022
Member
|
Thank you! |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Signature::from_bytes to take
[u8; 64]as argument ratherthan
&[u8]which:at compile time and
At the same time, since there’s already TryFrom<&[u8]> implementation
for Signature, no features are lost and clients who want to create the
signature from a slice can do it via Signature::try_from.
This does change the API but since the crate is currently in 2.0
preview stage, that should be fine since API breaking changes are
allowed by symantic versioning at major version upgrade.