Closed
Conversation
Backported cherry-pick of: ARMv8 `asm!` cleanups (#101) We pass in `state.as_mut_ptr()` as `x0`, which was previously marked as `in`. However, it's modified in the `asm!`, e.g.: sub x0, x0, #192 Note: it's also post-incremented by `ld1.1d` as state is loaded. Since it's modified, it needs to be `inout`. This marks it as such, using the `=> _` syntax to discard the result, then it's reset, then modified as state is written). Similar mutations were occurring with `x1` and `x8` as well, which have been modified accordingly.
tarcieri
force-pushed
the
keccak/v0.1.6
branch
from
3d6a43a to
a8936d9
Compare
Member
Usually I create a backport branch and merge backported PR into it. |
Member
|
Also please update changelog in the |
tarcieri
added a commit
that referenced
this pull request
Feb 13, 2026
One option is to also merge backport tags back into the master branch, then you don't get such warnings when looking at the tag: Currently going to this link displays the warning: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: not for merge, this just ties a PR to the release.
Backported cherry-pick of: ARMv8
asm!cleanups (#101)We pass in
state.as_mut_ptr()asx0, which was previously marked asin. However, it's modified in theasm!, e.g.:Note: it's also post-incremented by
ld1.1das state is loaded.Since it's modified, it needs to be
inout. This marks it as such, using the=> _syntax to discard the result, then it's reset, then modified as state is written).Similar mutations were occurring with
x1andx8as well, which have been modified accordingly.