Replace no_unroll feature(s) with soft-compact cfg#105
Merged
Conversation
Member
Author
|
Note: I can take a look at doing the same with the |
tarcieri
force-pushed
the
replace-no_unroll-feature-with-soft-compact-cfg
branch
from
cf62712 to
190bccd
Compare
Member
Author
|
Ugh @ formatting changes in the unrolling macros, let me make the edits in an editor that doesn't autoformat |
The following crates now have a new `cfg` for backend selection: - `ascon`: `--cfg ascon_backend="soft-compact"` - `keccak`: `--cfg keccak_backend="soft-compact"` This replaces the previous crate features, as suggested in #85
tarcieri
force-pushed
the
replace-no_unroll-feature-with-soft-compact-cfg
branch
from
190bccd to
3954968
Compare
Member
Author
|
Regarding the duplicated lint configs, we'd need support for merging crate-specific overrides into the workspace-level configs, which doesn't exist yet: rust-lang/cargo#13157 |
newpavlov
reviewed
Feb 13, 2026
| no_unroll = [] # Do no unroll loops for binary size reduction | ||
| simd = [] # Use core::simd (nightly-only) | ||
| asm = [] # Use optimized assembly when available (currently only ARMv8) | ||
| simd = [] # Use core::simd (nightly-only) |
Member
There was a problem hiding this comment.
Maybe it's worth to replace this features with the cfg(keccak_backend = "...") as well?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The following crates now have a new
cfgfor backend selection:ascon:--cfg ascon_backend="soft-compact"keccak:--cfg keccak_backend="soft-compact"This replaces the previous crate features, as suggested in #85