Implement Zeroize for NonIdentity#1832
Merged
Merged
Conversation
Member
The only disallowed value currently is the additive identity. You could potentially propose restricting some other values which clearly shouldn't be valid public keys. |
tarcieri
approved these changes
Apr 27, 2025
daxpedda
added a commit
to khonsulabs/traits
that referenced
this pull request
May 15, 2025
This PR implements `Zeroize` for `NonIdentity` setting it to `G` to prevent breaking any invariants.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements
ZeroizeforNonIdentitysetting it to G to prevent breaking any invariants.I just realized that
elliptic-curveaccepts G as a validPublicKey, which seems a bit dangerous to me. I guess 1 is also a validSecretKey. I have no idea if other libraries take these cases into account.