password-hash: remove Display/FromStr bounds on Params#2212
Merged
Conversation
For the associated type `CustomizedPasswordHasher::Params`, removes the `Display` and `FromStr` bounds which aren't actually used: for PHC-related purposes which are the only ones implemented directly in `password-hash`, it instead requires a `TryFrom<phc::ParamsString>` impl instead. Requiring these as well seemed like good hygiene so there's some way to serialize and parse the params as a string, but it becomes a problem when the params are shared between e.g. PHC and MCF implementations where each of them has a different params serialization so there's not one "true" serialization for which it actually makes sense to impl `Display` and `FromStr`.
tarcieri
force-pushed
the
password-hash/remove-str-bounds-on-params
branch
from
b87befd to
1431835
Compare
tarcieri
added a commit
that referenced
this pull request
Jan 22, 2026
For the associated type `CustomizedPasswordHasher::Params`, removes the `Display` and `FromStr` bounds which aren't actually used: for PHC-related purposes which are the only ones implemented directly in `password-hash`, it instead requires a `TryFrom<phc::ParamsString>` impl instead. Requiring these as well seemed like good hygiene so there's some way to serialize and parse the params as a string, but it becomes a problem when the params are shared between e.g. PHC and MCF implementations where each of them has a different params serialization so there's not one "true" serialization for which it actually makes sense to impl `Display` and `FromStr`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the associated type
CustomizedPasswordHasher::Params, removes theDisplayandFromStrbounds which aren't actually used: for PHC-related purposes which are the only ones implemented directly inpassword-hash, it instead requires aTryFrom<phc::ParamsString>impl instead.Requiring these as well seemed like good hygiene so there's some way to serialize and parse the params as a string, but it becomes a problem when the params are shared between e.g. PHC and MCF implementations where each of them has a different params serialization so there's not one "true" serialization for which it actually makes sense to impl
DisplayandFromStr.