Conversation
tarcieri
force-pushed
the
elliptic-curve/shorten-mul-by-generator-and-mul-add-vartime
branch
from
c4108fd to
fa812a4
Compare
It's already obnoxiously long, but this removes `*_point_*` from the previous `mul_by_generator_and_mul_add_point_vartime`. The RHS of the addition (`bP`) is a point-scalar multiplication, so just "point" alone doesn't add much additional clarity, and also the operation is already defined on e.g. `ProjectivePoint` making it somewhat redundant.
tarcieri
force-pushed
the
elliptic-curve/shorten-mul-by-generator-and-mul-add-vartime
branch
from
fa812a4 to
d15771f
Compare
tarcieri
deleted the
elliptic-curve/shorten-mul-by-generator-and-mul-add-vartime
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's already obnoxiously long, but this removes
*_point_*from the previousmul_by_generator_and_mul_add_point_vartime.The RHS of the addition (
bP) is a point-scalar multiplication, so just "point" alone doesn't add much additional clarity, and also the operation is already defined on e.g.ProjectivePointmaking it somewhat redundant.