aead: add alloc-based APIs to stream module#447
Merged
Conversation
Member
Author
|
This PR contains a bit more copy-paste than I'd like, which generally speaks to some composability problems with the current trait design (both in the That said, I'd like to at least spike out the functionality, and then pursue addressing the above by exploring some breaking changes to the |
tarcieri
force-pushed
the
aead/stream-alloc-support
branch
from
f63b187 to
2856751
Compare
Adds a corresponding set of allocating APIs to `StreamPrimitive`, `Decryptor`, and `Encryptor`.
tarcieri
force-pushed
the
aead/stream-alloc-support
branch
from
2856751 to
3c28547
Compare
Member
Author
|
Merging this, but will post a follow-up issue on some potential (breaking) ways to refactor and clean up the |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a corresponding set of allocating APIs to
StreamPrimitive,Decryptor, andEncryptor.