ctutils: downgrade MSRV to 1.85 #1259
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is implemented as its own PR so we can easily revert it when we are ready to bump MSRV to 1.87. The main thing we lose here is `const fn` support for `Choice::to_u8` and `to_bool`, since these use `black_box`. In addition the macros to write the signed impls of `CtEq` and `CtSelect` become a little uglier, but that's not the end of the world.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is implemented as its own PR so we can easily revert it when we are ready to bump MSRV to 1.87.
The main thing we lose here is
const fnsupport forChoice::to_u8andto_bool, since these useblack_box.In addition the macros to write the signed impls of
CtEqandCtSelectbecome a little uglier, but that's not the end of the world.