cmov: improve slice remainder handling #1377
Merged
+127
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
force-pushed
the
cmov/improved-slice-remainder-handling
branch
3 times, most recently
from
e9cfb0c to
1f64f5a
Compare
When chunking slices into words, instead of handling the remainder by iterating over it an element at a time, converts the remainder into a `Word` and applies either `Cmov` or `CmovEq` to the word. For `Cmov`, the computed `Word` is used to fill `dst_remainder`. The implementation is generic and used with `u8`, `u16`, and `u32`.
tarcieri
force-pushed
the
cmov/improved-slice-remainder-handling
branch
from
1f64f5a to
7bc7c82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When chunking slices into words, instead of handling the remainder by iterating over it an element at a time, converts the remainder into a
Wordand applies eitherCmovorCmovEqto the word.For
Cmov, the computedWordis used to filldst_remainder.The implementation is generic and used with
u8,u16, andu32.