base64ct: MSRV 1.47 and TODO fixes it enables#334
Merged
Conversation
tarcieri
commented
Mar 17, 2021
|
|
||
| #[inline(always)] | ||
| const fn encoded_len_inner(n: usize, padded: bool) -> Option<usize> { | ||
| // TODO: replace with `checked_mul` and `map` on stabilization |
Member
Author
There was a problem hiding this comment.
1.47+ lets us use checked_mul, but unfortunately map is not const fn in any release to date
All of the TODOs except for one are because `const fn` support for various methods isn't available until 1.47, and the previous MSRV was 1.46 instead. Therefore, this commit bumps MSRV from 1.46 to 1.47 (which will entail a minor version bump too)
tarcieri
force-pushed
the
base64ct/msrv-1.47-fixups
branch
from
6eeb9eb to
f950eb3
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All of the TODOs except for one are because
const fnsupport for various methods isn't available until 1.47, and the previous MSRV was 1.46 instead.Therefore, this commit bumps MSRV from 1.46 to 1.47 (which will entail a minor version bump too)