Improve float.fromhex module of objfloat#1552
Merged
windelbouwman merged 5 commits intoRustPython:masterfrom Oct 31, 2019
Merged
Improve float.fromhex module of objfloat#1552windelbouwman merged 5 commits intoRustPython:masterfrom
windelbouwman merged 5 commits intoRustPython:masterfrom
Conversation
added 2 commits
October 20, 2019 21:17
- Python float.fromhex can handle string of float and hex without `.` - For example '0.0', '-0.0', '0x0p0', '-0x0p0' - Add test case mantioned
Writtic
force-pushed
the
writtic/module_fromhex
branch
from
e676fd0 to
8e3cab4
Compare
- `expect` that can't express python vm error message changed to pattern match - Erase duplicated test case
Writtic
force-pushed
the
writtic/module_fromhex
branch
from
c94395f to
0d84b3f
Compare
Contributor
Author
|
This PR is needed to implement Check this link test_math.py#L1269 The link would help you understand this PR's purpose. |
- Use `or_else` instead of value condition and `match` statement - For floating-point input - Use `map_err` instead of `match ` statement - For hexadecimal floating-point input without dot
Writtic
force-pushed
the
writtic/module_fromhex
branch
from
50e0461 to
bbb2ef4
Compare
Writtic
commented
Oct 25, 2019
This was referenced Nov 2, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
float.fromhexcan handle string of float and hex without.0.0,-0.0,0x0p0,-0x0p0