Implement os.getgrouplist#2449
Merged
coolreader18 merged 7 commits intoRustPython:masterfrom Feb 12, 2021
Merged
Conversation
Closed
Member
|
Yeah, I think that'd be good! You can follow this blog post to add the unittest file. |
Contributor
Author
Thanks. Let me do that. |
07af036 to
6124f9f
Compare
6124f9f to
57ceebb
Compare
Contributor
Author
|
@coolreader18 I copied
And also I formatted |
coolreader18
approved these changes
Feb 12, 2021
Member
coolreader18
left a comment
There was a problem hiding this comment.
Thank you for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement
os.getgrouplist.Ref #1175
Question
Looks like we don't have test_posix.py to check
os.getgrouplist. Do we want to copy it fromCPython?