Disallow kwargs from genericalias __new__.#3404
Merged
Merged
Conversation
Member
|
it looks original code is still disallowing kwargs. is it changing error message? |
Member
Author
|
@youknowone Oh right, yeah, basically that, bad naming. |
Contributor
|
Good! Some incompatibility now become correct. rustpython>>>>> GenericAlias()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: Expected at least 0 arguments (0 given)
>>>>> kwargs = {"origin":int, "arguments":int}
>>>>> GenericAlias(**kwargs)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: GenericAlias() takes no keywordspython>>> GenericAlias()
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: GenericAlias expected 2 arguments, got 0
>>> kwargs = {"origin":int, "arguments":int}
>>> GenericAlias(**kwargs)
Traceback (most recent call last):
File "<stdin>", line 1, in <module>
TypeError: GenericAlias() takes no keyword arguments |
Snowapril
reviewed
Nov 3, 2021
8107457 to
ffd7e8c
Compare
Snowapril
approved these changes
Nov 3, 2021
Contributor
Snowapril
left a comment
There was a problem hiding this comment.
Totally looks good to me 😊
youknowone
approved these changes
Nov 4, 2021
Member
youknowone
left a comment
There was a problem hiding this comment.
The message "takes no keyword arguments" is commonly repeated. I wish we have a way to handle this better.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Snowapril a review would be great if you could.