Merged
Conversation
CHOUMnote
force-pushed
the
addWeakProxyStr
branch
from
15baf0a to
2d5bfb3
Compare
youknowone
requested changes
May 21, 2022
Lib/test/test_deque.py
Outdated
|
|
||
| # TODO: RUSTPYTHON | ||
| @unittest.expectedFailure | ||
|
|
vm/src/builtins/weakproxy.rs
Outdated
| use super::{PyStrRef, PyTypeRef, PyWeak}; | ||
| use crate::{ | ||
| class::PyClassImpl, | ||
| convert::ToPyObject, |
Member
There was a problem hiding this comment.
Suggested change
| convert::ToPyObject, |
unused import
vm/src/builtins/weakproxy.rs
Outdated
Comment on lines
+78
to
+80
| None => Err(vm.new_exception_msg( | ||
| vm.ctx.exceptions.reference_error.clone(), | ||
| "weakly-referenced object no longer exists".to_owned(), | ||
| )), |
Member
There was a problem hiding this comment.
this part is an exact repeat of error in getattr().
please create a function new_reference_error() not to manually repeat the exception creation.
CHOUMnote
force-pushed
the
addWeakProxyStr
branch
from
2d5bfb3 to
1dffba5
Compare
file : test_deque.py method : test_weakref() error occurred because the return value of str() was different so add __str__() in weakproxy Signed-off-by: CHOUMnote <rlawlgh1028@naver.com>
CHOUMnote
force-pushed
the
addWeakProxyStr
branch
2 times, most recently
from
7b34961 to
70c0c70
Compare
CHOUMnote
force-pushed
the
addWeakProxyStr
branch
from
70c0c70 to
fabcfa6
Compare
youknowone
approved these changes
May 21, 2022
Member
youknowone
left a comment
youknowone
left a comment
There was a problem hiding this comment.
looks good, thank you for contributing!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After a weakReference and str() call, the two values were different in comparison, resulting in an error
I found it, "weakproxy object" is not have "__str__()" so calling by "parent object" in "__str__()"
So I added in "weakproxy. rs" made it and "str()"method is work normally