Set comparator start location to beginning of comparison#4261
Merged
DimitrisJim merged 1 commit intoRustPython:mainfrom Nov 7, 2022
Merged
Set comparator start location to beginning of comparison#4261DimitrisJim merged 1 commit intoRustPython:mainfrom
DimitrisJim merged 1 commit intoRustPython:mainfrom
Conversation
Collaborator
Author
|
\cc @harupy |
youknowone
approved these changes
Nov 5, 2022
charliermarsh
force-pushed
the
charlie/comparator
branch
from
e996b25 to
6f17c4f
Compare
charliermarsh
force-pushed
the
charlie/comparator
branch
from
6f17c4f to
ba4beb5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now,
1 == 2has a start location at the first=. This PR changes the parser such that start location is equivalent to the start of theleftitem (i.e., the1).