This repository was archived by the owner on Mar 22, 2024. It is now read-only.
optimize count #7
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
approved these changes
Apr 20, 2021
src/engine.rs
Outdated
Comment on lines
1001
to
1005
| extern "C" { | ||
| fn tolower(c: i32) -> i32; | ||
| fn toupper(c: i32) -> i32; | ||
| fn isalnum(c: i32) -> i32; | ||
| } |
Member
There was a problem hiding this comment.
I don't think we should use the C functions here -- I don't think we really need to care about locales, and this adds an unnecessary dependency on libc. I think for the functions that take a u32, you can just use std::char::from_u32() instead of u8::try_from
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should no change need for rustpython.