Multiple framework targets and signed version in nuget package#31
Merged
brianjmiller merged 9 commits intomasterfrom Aug 10, 2017
Merged
Multiple framework targets and signed version in nuget package#31brianjmiller merged 9 commits intomasterfrom
brianjmiller merged 9 commits intomasterfrom
Conversation
bscSCORM
approved these changes
Aug 4, 2017
added 6 commits
August 8, 2017 12:46
samcayford
force-pushed
the
MultiTargetNuget
branch
from
3552407 to
5c442db
Compare
samcayford
force-pushed
the
MultiTargetNuget
branch
from
5c442db to
b07efe3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Set nuget to be "embedded" in project in a similar fashion to our other projects. This means dependencies will be pulled down on build without having to do anything in Visual Studio. (All the nuget files are automatically added by VS)
Renamed "Release" configuration to "Release-net35" and added further configs for net40, net45 and net45-signed.
Set Newtonsoft dll to NOT be "Copy Local" (
<Private>False</Private>) so that it doesn't end up in the .nupkg with the changes to.nuspec.Added new ant
build.xmlto build and package the.nupkg. Makes it a bit easier for now (saves manually selecting the config in VS and rebuilding a bunch of time) and will be useful if we ever move to building this on build server.