Unable to cast object of type 'Newtonsoft.Json.Linq.JProperty' to type 'Newtonsoft.Json.Linq.JObject'.#43
Closed
rasmuseeg wants to merge 2 commits intoRusticiSoftware:masterfrom
rasmuseeg:master
Closed
Unable to cast object of type 'Newtonsoft.Json.Linq.JProperty' to type 'Newtonsoft.Json.Linq.JObject'.#43rasmuseeg wants to merge 2 commits intoRusticiSoftware:masterfrom rasmuseeg:master
rasmuseeg wants to merge 2 commits intoRusticiSoftware:masterfrom
rasmuseeg:master
Conversation
Contributor
Author
|
Any change this can be merged and released quickly? |
Contributor
|
Rasmus, This looks good. Can you add a test to cover this change? While you're adding the tests, could you also remove the empty merge commit? I think your commit is valuable, so if you're unable to get around to this, I may go ahead and branch off of this and add the tests myself sometime in the next couple of days. |
Contributor
|
Going to go ahead and close this PR. It was a part of #45, which was just closed. Thanks for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue with the older spec.