Add the params in extended to the request URL#44
Merged
reedmclean merged 3 commits intomasterfrom Dec 17, 2018
Merged
Conversation
Member
brianjmiller
left a comment
brianjmiller
left a comment
There was a problem hiding this comment.
See comment, may need to discuss, otherwise I'm 👍 on this.
| if (req.queryParams != null) | ||
| String qs = ""; | ||
| qs = AppendParamsToExistingQueryString(qs, req.queryParams); | ||
| qs = AppendParamsToExistingQueryString(qs, extended); |
Member
There was a problem hiding this comment.
This isn't necessarily wrong, but is a bit different behavior than how the original instance of this works. Specifically, in TinCanJS here, we only include the value from extended if it isn't in the passed in props. We should be cognizant of the difference and whether it is intentional. It seems the other libs don't yet have support for extended either, so what we do here sets a bit of a precedent.
Contributor
Author
There was a problem hiding this comment.
That was not intentional. I will add the same logic that TinCanJS has.
brianjmiller
approved these changes
Dec 17, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
extendedwas already a property onRemoteLRSwith this intent, but it wasn't implemented yet. Now, if you want to append arbitrary parameters to the request URL, you can do so by setting values in theextendeddictionary.Also, I added default empty dictionaries to a few properties on
RemoteLRSas a small usability improvement.