Couple of quick enhancements#44
Merged
bscSCORM merged 5 commits intoRusticiSoftware:masterfrom Jun 19, 2013
Merged
Conversation
* Allow endpoint to be specified without trailing slash * Allow early configuration of alertOnRequestFailure * Add test coverage of LRS instantiation
Member
Author
|
@tseabrooks want to review? |
ghost
assigned
There was a problem hiding this comment.
Are these codes documented somewhere? If not whats the point other than just using the error message?
|
I'm ok with this. Though it feels like we are updating the version # too foten. I suppose it's semver but it still feels like we shouldn't update version with each checkin. @bscSCORM ready for merging. |
Member
|
semver pretty much requires changing the version with every checkin. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #39 (which is also part of #32) and part of #38.
Adds some test coverage for LRS and ActivityDefinition. Tested in: