Skip to content

Remove alert() usage#54

Merged
bscSCORM merged 2 commits intoRusticiSoftware:masterfrom
brianjmiller:master
Oct 25, 2013
Merged

Remove alert() usage#54
bscSCORM merged 2 commits intoRusticiSoftware:masterfrom
brianjmiller:master

Conversation

@brianjmiller
Copy link
Member

Time for these to go. Specifically fixes issue with them happening for 404's on document APIs where we use a 400 fake status for XDR because it doesn't report a real status.

@ghost ghost assigned brianrogers Oct 21, 2013
@brianjmiller
Copy link
Member Author

@brianrogers for review. Fixes #54. Tested in the various browsers.

@brianrogers
Copy link
Member

Looks good to me. To you @bscSCORM

bscSCORM added a commit that referenced this pull request Oct 25, 2013
@bscSCORM bscSCORM merged commit 2888cf2 into RusticiSoftware:master Oct 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants